Forums » Ruby-dev » test_accept_nonblock(TestNonblockSocket) and test_connect_no

(ArgumentError $B$G;_$^$C$F$$$k$N$G(B boron $B$N(B chkbuild 
$B$K$O=P$F(B
$B$-$F$$$^$;$s$,(B) $B0J2<$N$h$&$J<:GT$,5/$-$F$$$^$9!#(B

% ./ruby -v
ruby 1.9.0 (2006-06-25) [i686-linux]
% ./ruby test/runner.rb test/socket/test_nonblock.rb
Loaded suite test_nonblock.rb
Started
FF.....
Finished in 0.020617 seconds.

  1) Failure:
test_accept_nonblock(TestNonblockSocket) 
[/tmp/19/ruby/test/socket/test_nonblock.rb:18]:
<"\002\000\2254\177\000\000\001\000\000\000\000\000\000\000\000"> 
expected but was
<"\002\000\000\000\177\000\000\001\200\330\347\267\034\000\000\000X\263\317\277\000\000\000...\277\001\000\000\000">.

  2) Failure:
test_connect_nonblock(TestNonblockSocket) 
[/tmp/19/ruby/test/socket/test_nonblock.rb:43]:
<"\002\000\273\205\177\000\000\001\000\000\000\000\000\000\000\000"> 
expected but was
<"\000\000\000\000\004\000\000\000@\277\312\267\377\377\377\377\024\265\317\277\000\000\000...\347\267@\000\000\000">.

7 tests, 29 assertions, 2 failures, 0 errors

$B0JA0$OLdBj$J$+$C$?$O$:$@!"$H;W$C$FD4$Y$F$_$k$H!"7o$NBg$-$J%3(B
$B%_%C%H$N(B socket.c $B$NJQ99(B
http://www.ruby-lang.org/cgi-bin/cvsweb.cgi/ruby/ext/socket/socket.c.diff?r1=1.170;r2=1.171
$B$NCf$N0J2<$NJQ99$N$h$&$G$9!#(B

@@ -2948,18 +2824,15 @@ sock_recvfrom_nonblock(int argc, VALUE *
 }

 static VALUE
-sock_accept(sock)
-    VALUE sock;
+sock_accept(VALUE sock)
 {
     OpenFile *fptr;
-    VALUE sock2;
     char buf[1024];
     socklen_t len = sizeof buf;

     GetOpenFile(sock, fptr);
-    sock2 = s_accept(rb_cSocket,fptr->fd,(struct sockaddr*)buf,&len);
-
-    return rb_assoc_new(sock2, rb_str_new(buf, len));
+    return rb_assoc_new(s_accept(rb_cSocket,fptr->fd,(struct 
sockaddr*)buf, &len),
+                       rb_str_new(buf, len));
 }

 /*
@@ -3011,17 +2884,16 @@ sock_accept(sock)
  * * Socket#accept
  */
 static VALUE
-sock_accept_nonblock(sock)
-    VALUE sock;
+sock_accept_nonblock(VALUE sock)
 {
     OpenFile *fptr;
-    VALUE sock2;
     char buf[1024];
     socklen_t len = sizeof buf;

     GetOpenFile(sock, fptr);
-    sock2 = s_accept_nonblock(rb_cSocket, fptr, (struct sockaddr *)buf, 
&len);
-    return rb_assoc_new(sock2, rb_str_new(buf, len));
+    return rb_assoc_new(s_accept_nonblock(rb_cSocket, fptr,
+                                         (struct sockaddr *)buf, &len),
+                       rb_str_new(buf, len));
 }

 /*

ISO $B$K$N$j$3$s$G(B C $B$N0z?t$NI>2A=g=x$r:8$+$i1&$K7h$a$5$;$k!"(B
$B$H$$$&$s$G$J$1$l$P!"$3$l$O(B revert 
$B$,E,Ev$G$O$J$$$+$H;W$$$^$9!#(B

$B$^$D$b$H(B $B$f$-$R$m$G$9(B

In message "Re: [ruby-dev:28861] 
test_accept_nonblock(TestNonblockSocket) and 
test_connect_nonblock(TestNonblockSocket) failure"
    on Mon, 26 Jun 2006 13:09:48 +0900, Tanaka Akira <akr@m17n.org> 
writes:

|(ArgumentError $B$G;_$^$C$F$$$k$N$G(B boron $B$N(B chkbuild $B$K$O=P$F(B
|$B$-$F$$$^$;$s$,(B) $B0J2<$N$h$&$J<:GT$,5/$-$F$$$^$9!#(B

|ISO $B$K$N$j$3$s$G(B C $B$N0z?t$NI>2A=g=x$r:8$+$i1&$K7h$a$5$;$k!"(B
|$B$H$$$&$s$G$J$1$l$P!"$3$l$O(B revert $B$,E,Ev$G$O$J$$$+$H;W$$$^$9!#(B

$B$"!<!"(Brevert$B$7$^$7$g$&!#$9$$$^$;$s!#(B